Guillaume Lathoud

Results 9 comments of Guillaume Lathoud

...because of `.decl( 'mean_value', get_mean )` ...must have been the heat...

...but actually can be solved in a constructive manner: since #7 we already have inlining of some external functions (see fext, flatorize). We could also inline the code generated by...

Also interested in this, because of a use case flying close to the ground with a highly detailed elevation model. In that use case the performance degradation from 1.92 to...

Experimented a bit. Further below I give a possible solution for performance improvement. In [AtmosphereCommon.glsl](https://github.com/xtassin/cesium/blob/e5d81964ac4df545a31e3179a9fbd1726c981b80/Source/Shaders/AtmosphereCommon.glsl) I tried to lower the original constants `(PRIMARY_STEPS:16,LIGHT_STEPS:4)` down to `(4,2)` . This sure improved...

> Thanks for investigating @glathoud! Do you have screenshot comparisons of the results? On my use case, yes, see below screenshots [1] [2]. > If it's not too noticeable of...

Basically in [3][4] the sky looks like early morning before sunrise.

I fixed the explanation of what I did, fixed comments in the code, but the actual code remains unchanged.

@ggetz Sure, looking at the PR.

@ggetz Ok the PR is ready: https://github.com/CesiumGS/cesium/pull/11109