Milan Nikolic

Results 380 comments of Milan Nikolic
trafficstars

I have a wrapper for MuPDF here https://github.com/gen2brain/go-fitz that can be used for extracting the cover image. It uses static libraries bundled in the repo. Not sure if there is...

I didn't try yet, but there should be no problems. I know there are issues when libs are in git submodule, but not sure what happens with ${SRCDIR} that is...

I solved this by adding `LoadState`, like this https://github.com/gen2brain/go-health/commit/fd2225e1f326134d0f30418592ddae1a77de2347, and it works as expected. Still, I would prefer to not use my fork.

I added Windows support in https://github.com/gen2brain/go-libtor. I didn't try to build from Windows yet, all was done cross-compiling from Linux. I did have to patch a couple of `rpc*` headers...

@bobbaker6667 You can drop those build tags, they are not used. As I mentioned I had to patch a few rpc* files that come with MinGW runtime, maybe also something...

@psycik Thanks for checking, I believe the issue is not with filename/extension too long, because none of the filenames exceed 255, but there are 1100+ files per platform, perhaps that...

@bobbaker6667 I agree it is nice to not depend on CGO, but in my case, I was already using Qt and libmpv/ffmpeg with all the dependencies, at that point, I...

x264 param has this `IFpsNum uint32` in param, and int is converted to uint32. Do you have any issues with this? You can round however you want and pass that...

x264 API uses uint32, I cannot change that. You are in control, check camera fps, round numbers as you like and just pass that to encoder.

This should be fixed in https://github.com/gen2brain/x264-go/commit/a0a7bbb625389d9d5aa1e1b61ff642e027eebb2b. Can someone also test? I tried with a screengrab example and with 60fps, MPV correctly reports it.