Mahmoud Mazouz
Mahmoud Mazouz
> The error in the CI is a false positive, `Value` is used in `zenoh/tests/session.rs` in line 172 I don't know what to do. When I execute the command on...
@wyfo Please change the base branch to `dev/1.0.0` as `protocol_changes` is no longer the development branch.
> @fuzzypixelz could you please explain why you rewrote all the subject combinations logic? The previous logic worked and supported adding any new `Subject` type with very minor changes, and...
> > I would rename "declare_subscriber" to "subscriber_declaration", "declare_queryable" to "queryable_declaration", "put" to "publication" and "get" to "query". > > The idea is to use nouns instead of verbs now...
> The mapping has nothing to do with Rust types but with the Zenoh API and semantics. @Mallets My argument wasn't centered around the Rust API names, I was just...
> @fuzzypixelz what's the status of this PR? Is it ready for review? Right now it seems to report incorrect MSRVs. I would have to investigate that first.
The issue wasn't that the job was reporting incorrect MSRVs. But that the MSRV of the crate `zenohd` depends on the target platform it's compiled for. On the ubuntu-latest runner...
The problem now is handling platform-specific MSRVs. Right now we check that the `rust-version` field is equal to the MSRV. If crate C1 on platform P1 has an MSRV of...
The other problem is that cargo-msrv fails to install toolchains on windows-latest with error: ```console error: could not create link from 'C:\\Users\\runneradmin\\.cargo\\bin\\rustup.exe' to 'C:\\Users\\runneradmin\\.cargo\\bin\\cargo.exe' ``` It seemingly cannot create a...
> _Advanced Pub/Sub_ is now available in `main`. @fuzzypixelz is this PR still relevant? I think so, I don't think that the publication cache code has changed.