zenoh icon indicating copy to clipboard operation
zenoh copied to clipboard

Published 20 hours ago • verified publisher icon eclipse-zenoh

Stop publication cache task on disconnected channels

Open fuzzypixelz opened this issue 11 months ago • 3 comments

While debugging https://github.com/ZettaScaleLabs/rmw_zenoh/issues/44, GDB backtraces showed that the Net runtime was apparently blocked executing this publication cache task; applying this patch solved the issue.

Even though the blocking behavior I observed might've been a consequence of different underlying issue, I think this patch should be applied anyway. This is because:

  1. If I understand correctly, the tokio::select! macro doesn't execute poll each branch on every iteration, but rather uses a random number generator to choose the branch.
  2. Errors should be handled ;)

fuzzypixelz avatar Dec 17 '24 13:12 fuzzypixelz

Advanced Pub/Sub is now available in main. @fuzzypixelz is this PR still relevant?

Mallets avatar Feb 10 '25 09:02 Mallets

Advanced Pub/Sub is now available in main. @fuzzypixelz is this PR still relevant?

I think so, I don't think that the publication cache code has changed.

fuzzypixelz avatar Feb 10 '25 12:02 fuzzypixelz

Is the plan to merge it anyways? Knowing that querying subscriber has been marked as deprecated?

Mallets avatar Feb 10 '25 12:02 Mallets