frantran

Results 7 comments of frantran

@ArthurMa1978 can you please review?

affected by breaking change issue: /Users/francis/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public System.Nullable Azure.ResourceManager.ContainerServiceFleet.Models.ContainerServiceFleetManagedClusterUpdate.SelectionType.get()' does not exist in the implementation but it does exist in the contract. [/Users/francis/go/src/goms.io/dotnet-stuff/autoupgrade-api/azure-sdk-for-net/sdk/fleet/Azure.ResourceManager.ContainerServiceFleet/src/Azure.ResourceManager.ContainerServiceFleet.csproj::TargetFramework=netstandard2.0] /Users/francis/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error...

> affected by breaking change issue: > > /Users/francis/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public System.Nullable Azure.ResourceManager.ContainerServiceFleet.Models.ContainerServiceFleetManagedClusterUpdate.SelectionType.get()' does not exist in the implementation but it does exist in the contract....

> LGTM. Two comments: > > * Since there is addition of API, it would be better to add test cases. > * For changelog, just briefly mentioned the major...