Steffen Forkmann

Results 461 comments of Steffen Forkmann

So everything compiles, but ![screenshot_20190221-121514](https://user-images.githubusercontent.com/57396/53165224-71ca5300-35d2-11e9-9c8d-f6ecce64372f.jpeg) https://github.com/react-navigation/react-navigation/issues/2767#issuecomment-347302691 suggest there is some trouble with the import. https://stackoverflow.com/a/47871724/145701 suggests there needs to be some additonal export!? But I don't see what changed. @alfonsogarciacaro...

@MangelMaxime I assume we need to "export" Elmish.ReactNative.Components.App somehow!? https://github.com/elmish/react/blob/master/src/react-native.fs#L15

https://github.com/elmish/react/commit/c6c15b5311dc4e6d75fa9fbf1b5654def0003f8c#diff-ce3e72f76b021b9de55e8aba30e99cf5R45 looks like @alfonsogarciacaro already fixed something for fable2. how can I test that?

yes that's the correct change. good work @alfonsogarciacaro just the issue is: there is no compatible package of this released

fix would be enough. let me test the new packge

confirmed. Fable.Elmish.React 2.2.0 fixed it. thanks! now I'm down to warnings. ![screenshot_20190221-133821](https://user-images.githubusercontent.com/57396/53169619-14d49a00-35de-11e9-83be-cf824fb5f9f2.jpeg) it complains about line 59 in ![image](https://user-images.githubusercontent.com/57396/53169704-4c434680-35de-11e9-8b60-d3f8840de2c9.png)

const logo = createElement(Image, createObj(ofArray([new Props.ImageProperties(5, require("../../images/raven.jpg")), new Props.ImageProperties(6, ofArray([new Props.FlexStyle(1, "center"), new Props.FlexStyle(10, "column")]))]), 1)); this is how fable did it in 1.x

so we need to update the bindings?

Tbh I don't mind making it breaking (it's already breaking anyway) - I want it look work as close as possible like React proper. Alfonso Garcia-Caro schrieb am Fr., 22....

let's go with option 1: what do I need to do?