Folkert de Vries

thanks for reporting this and providing such a nice reproduction. This exposed a subtle bug in zlib-rs that I've now fixed locally. We'll publish a new version next week and...

well that error is in glibc, not in anything that we directly control. The `bzip2-sys` crate is ancient, and so to keep much older versions working we've tried to not...

you want a very new resolver but a very old msrv? Anyway, it looks like we, by default, select `cc` at version `1.1.1`, which as msrv `1.67.0`, so maybe we...

> Decide: Should we allow signed integers in simd_fsh{l,r}? Both `s390x` and `avx512` do (want to) use the funnel shifts on signed types. We can use transmutes there of course,...

probably https://github.com/rust-lang/rust/pull/128852 is needed to fix the suggestion here and correctly insert the unsafe keyword

Thanks for the review! I've handled the comments and also rebased because some CI things had changed.

Hmm, formatting does not really help much, because formatting in asm is undefined. So let's leave it as it is. I did merge the definition for `sdx` into the normal...

Well currently the bootstrap compiler rejects `#[unsafe(naked)]`, so we're using `#[cfg(bootstrap)]` to make that work in some other places in `compiler-builtins`. Similar, bootstrap would still reject `#[rustc_std_internal_symbol]` in combination with...

The indenting is nicer, yes (though rustfmt is still a bit wonkey sometimes). The PR allowing `rustc_std_internal_symbol` on naked functions was merged on May 2nd https://github.com/rust-lang/rust/pull/140552, and the bootstrap compiler...

Hmm, maybe? We might also be able to "fix" the mangling on the rustc side with `cfg(bootstrap)` too? Did you ever get using a git dependency for compiler-builtins in rustc...