Andy Walker

Results 197 comments of Andy Walker

Thanks @tisonkun! We might want to open the issue for discussion first before we issue PRs, since the current API and mine are fairly different, and it might help to...

Went ahead and tossed a couple PRs your way, if they suit you. I could go either way between `ExpectResults` and `ExpectRows`, but `ExpectResults` is at least symmetrical with the...

I'd like to push back a little on this being just a doc change before I give up the ghost. I see your point wrt control flow; however, I also...

In light of the [contribution guide rework](https://github.com/zombiezen/go-sqlite/commit/a82f99ef84c341cf3a5abab95dd49a10908ccd8f), now I'm worried I'm being too presumptuous 😔. If you'd prefer, I can close the PR and move the above to a discussion....

As requested! https://github.com/zombiezen/go-sqlite/discussions/90

Some selected `go test -v` output (forgive the line numbers, I got a little carried away with `t.Helper()`) ``` === RUN TestPoolAcquireReusesResources puddle/tracing.go:67: got new resource after 21.958µs. blocked for...

> log.Logger has an optimization where it detects when the writer is io.Discard and does no allocations. Maybe slog should do the same thing. I'm not sure this would work...

> I wouldn't want to make a nil *Logger meaningful. I think it would lead to hard-to-find errors where forgetting to set a logger resulted in no log output, and...

The only reason to prefer `DiscardLogger() *Logger` might be that it could be created fresh on invocation, which would prevent dependencies from mucking about with `slog.DiscardHandler`, though the flip side...