Andy Walker

Results 180 comments of Andy Walker
trafficstars

I think this would compromise the ergonomics of the library by imposing ordering that you'd need to look at the arguments to know. The only two-argument method currently in the...

This is a known issue with running tests with `-json`, since test2json parses the output of Go tests, and direct outputs to stdout and stderr can cause this to become...

Tentatively, a fix for this would involve retrofitting `is.I` to ditch taking function references to `t.Fail` and `t.FailNow` in favor of calling them directly with the log message, and adding...

To avoid breaking pre-1.7 compatibility (if we really care about going that far back), it would probably also be a good idea to denormalize the pre-1.7 code into a single...

I think ergonomics are a founding principle of the module as I understand it. so readability is paramount, and the nested code is much harder to read. Plus, there's already...

I have created a workaround for this in Javascript cribbed initially from [this stackoverflow answer](https://stackoverflow.com/questions/75736981/context-stroke-and-context-fill-for-markers-in-svgs-on-chrome-dont-work-altern), and modified to work with the current mermaid svg output and both start and end...

Huh, you know, originally I was thinking I could make this work for other diagram types, but now that I think about it, I guess flowcharts are really the only...

> Would also love to have control over the arrow head color. Looking to use this on my site with a dark background. the black heads just disappear. @0xdf223 you...

The best bet here is probably to add a configuration flag like `quotedArrowLabels` to avoid breaking backwards compatibility. This would (optionally) force the user to have paired characters around arrow...

@nirname > There is a draft https://github.com/mermaid-js/mermaid/pull/4019 by @brvv Yeah, I saw that! In fact, it was the author calling out that ambiguity that made me consider an alternate approach....