arduino

arduino copied to clipboard

unit tests for FirmataParser

3

Now that the parsing functionality has been extracted from the Arduino-specific Firmata.cpp implementation, it would be useful to add unit tests for FirmataParser. Existing tests use ArduinoUnit which runs on...

soundanalogous

`FirmataParser::attach(uint8_t, sysexCallbackFunction)` usage is misleading

2

`FirmataParser::detach` only checks for `START_SYSEX`, but `FirmataParser::attach` will accept any variable as `command` argument. To be consistent, it feels like `FirmataParser::attach` should require `START_SYSEX` or do nothing.

zfields

swapped HardwareSerial for Stream in Firmata.cpp

7

I realized that Firmata.cpp should include Stream.h rather than HardwareSerial.h since any type of Stream may be used with Firmata. I've updated the examples to include HardwareSerial.h before Firmata.h. This...

soundanalogous

I will pick on `byte`, because it's the biggest offender. `byte` is nothing more than a `typedef` of `uint8_t`, but `byte` is not portable and `uint8_t` is. This is an...

zfields

`void FirmataClass::sendSysex(byte command, byte bytec, byte *bytev)` `typedef void (*sysexCallbackFunction)(uint8_t command, uint8_t argc, uint8_t *argv);` in `FirmataParser` Since parameter `bytec` is used for counting the number of bytes, it would...

zfields

Arduino Zero uses 12-bit ADC

1

Configuration query for Arduino Zero should return 12 rather than 10 for analog pins. Check for a constant in pins_arduino.h that defines the analog resolution. If that doesn't exist, add...

soundanalogous

enable saving board state in EEPROM as an option

2

This has come up several times in the past and would be worth revisiting. Past discussions were about whether or not board state should always be stored in EEPROM. I...

soundanalogous

Extra preceding bit is always sent to HardwareSerial (Serial1, Serial2, Serial3)

4

When I use StandardFirmata on Arduino Due and connect it with a serial servo motor with Serial1 on pins 19 (RX) and 18 (TX), the servo motor does not work....

thorikawa

Setting defined output states after upload

4

Problem: After loading StandardFirmata into the Arduino, the GPIOs are in undefined state, destroying turnouts of my model railway. I despartely need a quick & dirty solution: After loading Firmata,...

andizota

ability to read non changing digital input

2

Because Firmata only reports digital input values on change (via `DIGITAL_MESSAGE`), it is currently difficult to read a non-changing digital input. Currently there is only one way a non-changing digital...

soundanalogous