Linus Färnstrand

Reviewed 1 of 8 files at r2, 1 of 3 files at r11. Review status: all files reviewed at latest revision, 14 unresolved discussions. --- *[a discussion](https://reviewable.io:443/reviews/mullvad/system-configuration-rs/8#-L7RdOHxnKEma1aN1oiN:-L7RdOHyiizVXnsv7VGn:b-dwkavp) (no related file):*...

Review status: 2 of 6 files reviewed at latest revision, 14 unresolved discussions, some commit checks failed. --- *[a discussion](https://reviewable.io:443/reviews/mullvad/system-configuration-rs/8#-L7RdOHxnKEma1aN1oiN:-L7_y0-XcJJ284sK4r_9:brjutp) (no related file):* Previously, faern (Linus Färnstrand) wrote… @luozijun I...

Review status: 0 of 6 files reviewed at latest revision, 15 unresolved discussions. --- *[system-configuration/src/lib.rs, line 26 at r13](https://reviewable.io:443/reviews/mullvad/system-configuration-rs/8#-L7zxTt5V2X2iYaZC3dj:-L7zxTt5V2X2iYaZC3dk:b-68loxb) ([raw file](https://github.com/mullvad/system-configuration-rs/blob/7e8771b1e278893c6c764e5bdeb7e346c7a9006b/system-configuration/src/lib.rs#L26)):* > ```Rust > extern crate system_configuration_sys; > #[cfg(all(feature =...

Ping @luozijun :) Felt like we were pretty close to merge with this PR. --- Review status: 0 of 6 files reviewed at latest revision, 15 unresolved discussions. --- *Comments...

Please also squash some of your git history to tidy it up a bit :pray:

This and more access flags have now been merged as part of #129

That complexity does not sound like something that `windows-service` should be responsible for. Less black magic and more control to the developer if they do it themselves before calling into...

> > Absolutely everything regarding the internal details of these errors are exposed > > Still don't understand why it's bad Again, see https://github.com/mullvad/udp-over-tcp/pull/57. If every aspect of the error...

Thanks for wanting to contribute! However, we merged a different solution to this issue over in #107. The main issue in this PR was how the entire API of the...

Thanks for wanting to contribute! However, due to inactivity (from both sides I have to say), this is superseded by #56