Linus Färnstrand

Might be a cool idea. But on our end this crate is mostly in low maintenance mode. It works for our use case and we are currently not planning on...

Looks good to me! We'll incorporate this in our bash coding guidelines one way or another. Thanks.

Thank you. But I don't think we want too much churn in our bash scripts. We have plenty of scripts where we don't follow our own guidelines perfectly. So I...

@LuoZijun Thanks for your contribution! I don't mean to run over your work and I'm sorry if I made you feel I did. But I prefer automatically generated bindings for...

@LuoZijun PR #9 is now merged. So you can rebase on latest master. Please also note that I merged two other PRs, adding Travis CI, you can check there if...

@LuoZijun Sorry for being so slow reviewing. We want this merged and it's constantly getting better, so it's awesome. But I've been very busy lately. I'll continue reviewing whenever I...

@LuoZijun Ah, the part with configuring DNS on Windows sounds very interesting. We actually need that for the same product (the VPN app) that uses this library for setting DNS...

Reviewed 1 of 8 files at r2. Review status: all files reviewed at latest revision, 25 unresolved discussions. --- *[system-configuration/src/lib.rs, line 19 at r11](https://reviewable.io:443/reviews/mullvad/system-configuration-rs/8#-L7P0U9WXBFB9ZXwQFhg:-L7P0U9XL4nQgK1nciqi:b9ys9qm) ([raw file](https://github.com/mullvad/system-configuration-rs/blob/c070df9f6041819f9182daa05212b25401f8fe6e/system-configuration/src/lib.rs#L19)):* > ```Rust > //!...

Review status: all files reviewed at latest revision, 22 unresolved discussions. --- *[system-configuration/src/network_configuration.rs, line 188 at r5](https://reviewable.io:443/reviews/mullvad/system-configuration-rs/8#-L5lHuuGgIlcwfCL0wQ6-r5-188:-L7P3z6LutnXcTtMl0VO:b-3mzqw1) ([raw file](https://github.com/mullvad/system-configuration-rs/blob/1bb3afba76fc206ba450bb8f91c518cedcc2f674/system-configuration/src/network_configuration.rs#L188)):* From the docs: > The ordered list of service identifiers associated...

Review status: all files reviewed at latest revision, 21 unresolved discussions. --- *[system-configuration/src/network_configuration.rs, line 360 at r7](https://reviewable.io:443/reviews/mullvad/system-configuration-rs/8#-L5lHuuGgIlcwfCL0wQ6-r7-360:-L7P9o3-19nVcev8r8WD:b-zhmloc) ([raw file](https://github.com/mullvad/system-configuration-rs/blob/b02a29714041b0ba0bd7e569ee9da04d8c4d8248/system-configuration/src/network_configuration.rs#L360)):* Previously, faern (Linus Färnstrand) wrote… Is it not possible to remove...