chromium-codereview
chromium-codereview copied to clipboard
esprehn
A chrome extension that changes the frontend to Rietveld for Chromium
It would be good to have keyboard navigation to go to the next / previous modified chunk / file in the review tool so that we can easily review a...
Some of my CL (https://codereview.chromium.org/771723002 for example) requires LGTM from more than one OWNERS however, when I check the dashboard view, the status is green (https://codereview.chromium.org/). I can get the...
Visit this issue and view monitoring/go/datahopper/main.go in the new (non-deprecated) UI. https://codereview.chromium.org/761433005/ You will notice line 35 in the left hand column is missing. I also believe the line numbers...
When reviewing diffs, there are link to provide more context. It would be useful to be able to collapse the context when it is no longer required (otherwise the scrolling...
In the normal rietveld UI, you can diff against previous patchsets. This feature is particularly useful for multiple rounds of review (what have they changed since I last left comments?)...
How to reproduce: - Open https://codereview.chromium.org/558163004/ - Click on "Show diffs" on patchset 3 - Observe that LayoutTests/fast/css-grid-layout/grid-template-areas-empty-string-crash.html has no content, though if you check the raw diff you can...
See screenshots. In the first screenshot, the beginning of the multiline string is not in the diff (although it is in the context snippet), but the end it. This appears...
We just need to add a "\n" in the newline diff output.
The "Show context" links around a section of a diff should be able to display fewer lines than "the whole rest of the file". Common numbers are +5, +10, +50,...
The pinkish highlighting that is used to show "nothing changed here" isn't sufficiently visually distinct from the green and red highlighting used to show lines added/removed. Especially because it contains...