Eric Hanson
Eric Hanson
Could we drop support for pre-Julia 1.6 in RegistryCI @DilumAluthge?
I think this is pretty simple and uncontroversial so I'll merge soon
~~Testing is slightly tricky here since this is the first integration test case which also fails the consistency tests (not just automerge). We run those on all integration tests by...
ah ok looking into it more, it turns out I misunderstood the role of `update_status`. I thought it was an early exit so we don't run the rest of the...
I'm so confused about ``` ERROR: LoadError: LoadError: LoadError: syntax: invalid keyword argument syntax "new_package_waiting_period" Stacktrace: [1] top-level scope at /home/runner/work/RegistryCI.jl/RegistryCI.jl/src/AutoMerge/pull_requests.jl:174 ```
Yeah, I knew that... but still left one in. It was very confusing because the stacktrace pointed to the wrong file I think. It said ``` [1] top-level scope at...
I think we wanted to make sure the license was somewhere "obvious" and not buried, so we didn't just check all subdirs. But `LICENSES` seems obvious enough, seems OK to...
I think the way to do this without needing an unpacked registry would be for someone to help setup https://github.com/GunnarFarneback/RegistryInstances.jl as a stable face in front of Pkg's registry-handling internals...
In terms of a timeline, I'd actually prefer to let the current version simmer for a bit. We haven't seen any false positives yet, and with the relaxed rules (just...
If we change (1) in Stefan's post to our current "license file autodetection" which checks either all top-level files including those three when they exist (if there are fewer than...