RegistryCI.jl
RegistryCI.jl copied to clipboard
thread `new_package_waiting_period` through to AutoMerge comment
Based on #548 which should get merged first
closes https://github.com/JuliaRegistries/RegistryCI.jl/issues/413, which is a recurring source of confusion on our private registry that uses a much lower number here
I'm so confused about
ERROR: LoadError: LoadError: LoadError: syntax: invalid keyword argument syntax "new_package_waiting_period"
Stacktrace:
[1] top-level scope at /home/runner/work/RegistryCI.jl/RegistryCI.jl/src/AutoMerge/pull_requests.jl:174
I'm so confused about
ERROR: LoadError: LoadError: LoadError: syntax: invalid keyword argument syntax "new_package_waiting_period" Stacktrace: [1] top-level scope at /home/runner/work/RegistryCI.jl/RegistryCI.jl/src/AutoMerge/pull_requests.jl:174
Do you have something of the form f(; new_package_waiting_period)?
IIRC, that doesn't work on Julia 1.3. You'll need to do f(; new_package_waiting_period=new_package_waiting_period) instead.
Yes, the kwarg shortcut arrived in Julia 1.5.
Yeah, I knew that... but still left one in. It was very confusing because the stacktrace pointed to the wrong file I think. It said
[1] top-level scope at /home/runner/work/RegistryCI.jl/RegistryCI.jl/src/AutoMerge/pull_requests.jl:174
but that line seemed fine.