Eran Leshem

Results 47 comments of Eran Leshem

> I'd say both, so on top you have the view with the description, and below the usual popup keyboard. Either one of these may not be available for any...

> > The thing is not all emojis have descriptions available. > > Is this still valid with the CLDR descriptions? Yes, not all emojis have CLDR entries, and not...

Just committed a new implementation, which takes descriptions from a dictionary, and displays them using a new popup text view. It also adds a setting. Questions: 1. Any idea about...

> why do you create another keyboard? What's the alternative? > I guess this might be necessary when there are parallel calls to `getSuggestions` on the same dictionary? For testing...

> my idea way getting some kind of offset from the popup keyboard (maybe whether popups are displayed or not is already enough). The offset could be added to the...

Is it a bug that adding/removing/replacing a dictionary requires an app restart?

> https://github.com/Helium314/HeliBoard/blob/main/app/src/main/java/helium314/keyboard/latin/SingleDictionaryFacilitator.kt#L20 Thanks. How do I get a `Dictionary` to pass to it?

> after you long-press an emoji and a description (only) pops up, the emoji does _not_ get inserted. I fixed this inconsistency - now the emoji always gets inserted after...

> Dictionaries are extracted only when they are needed, i.e. we have a dictionary in assets with a type that is not available in the cached dictionaries (`DictionaryFactory` line 37)....

Not sure I follow. You mean that if we add an emoji dictionary to assets, and the user doesn't add it to their list of dictionaries, I'll have to do...