Shane Freeder

Results 445 comments of Shane Freeder

build failure, if we're also caring about names, I'd much rather that new packets just use their mojmap'd counterparts, I believe we'd be okay doing that and it would generally...

The issue here is that we're always rewrapping stuff into a VanillaCustomGoal

Trivial fix, just need to not wrap if we don't need to wrap

This generally looks inherently dangerous in the long run, and fairly bad in the short term You have no idea what the actual interaction result from the event is, and...

having a skim, so far outside of what MM has pointed to, this generally looks fine; I'd need to double check that API def of that method, however

Concern is more "what's empty" for me

From the looks of this, this is generally down to spigot not properly adopting upstream changes for the past 10 years, this is fixable in the long run, but not...

The entire issue here is that the inventory you create with createInventory is a CraftCustomInventory which has 0 understanding or representation of the underlying inventory in use here. Combine that...

This is 100% not something that can be done mid patch release, this is more a major change in behavior in which needs to be done on a major release...

a config option was proposed for /stop to boot everybody, but there is no expectation that it would change event behavior, the server has stopped ticking and many things relied...