Shane Freeder

Results 445 comments of Shane Freeder

I recall lucko created a PR to spigot years ago to try to add a means to control buffering and releasing the rcon response, it is something I've wanted to...

recommended java version just seems completely irrelevant to the distribution system

My issue is, what constitutes as recommended? Tagging the build version is trivial, but, the notation of recommendations is somewhat iffy as we always just recommend the latest version that...

We maintain it on the docs in a place which isn't updating the metadata of several dozen builds at once? Unless you mean per release in which kills the granularity...

making stuff nullable in your case is not really going to change much, you remove the entry from the list, so there is nothing to upsert, and so we'd enter...

the forwarding mechansim is irrelevant for RegisteredServer#ping(), we pass through the hostname as defined in the servers list, for an actual player, we try to pass through the players vhost...

https://github.com/PaperMC/Velocity/blob/afd8b55fb52daa36e59f10b3ceb1fa953c29c485/proxy/src/main/java/com/velocitypowered/proxy/command/brigadier/StringArrayArgumentType.java#L49

Closed in favour of #1326 as this is sending packets in the wrong direction

ClientConfigSessionHandler is receiving packets from the client, hence why it has logic to write to the connection in-flight, so I'm honestly not sure how this would fix anything *scratches head*

sunday, bad eye; Using a map like that would also create dozens of issues if multiple things tried to request that data