Shane Freeder

Results 453 comments of Shane Freeder

Not really sure how we'd deal with this, as this doesn't even sound like an issue on our side, more on jline's

This should probably be shoved under the game mechanics section

Changes fixing issues induced by patches should go into the original patch, rather than as an extra patch down the line; I'm also not fond of this fix as it's...

I think mojang added a bunch of logic in the same place as we did, and there was a general "we're leading to the same behavior here"; I would try...

We've already hardline no'd a `paper()` method, it just creates so much pointless call cludge to avoid the odd cases where upstream does something which screws us over, and just...

this is API, not internal code stuff, so, probably 1000% unrelated to what you're talking about

I'm probably a bit rambly as I'm outta spoons for today, long term goal has always been to restore parity with vanilla, but, given that we're layers down the stack,...

Paper follows upstreams API contract of providing 0 promises over what the caller provides here, idk if there's much inclination to change that. While the implementation, at the moment, will...

Saying it's not encouraged to provide a mutable collection changes nothing in regards to the API contract here. Saying that it'l never be immutable when provided by paper is not...

I mean, java shamefully doesn't have a good way to represent im/mutable characteristics of a collection, but, I think making any promises around if the viewers list is flawed, it...