Paper icon indicating copy to clipboard operation
Paper copied to clipboard

Fix OfflinePlayer#getPlayerProfile returning deprecated type

Open Machine-Maker opened this issue 3 years ago • 2 comments

OfflinePlayer has a method, getPlayerProfile, that returns the deprecated bukkit PlayerProfile type. This changes that to use our interface which is a subtype of bukkit's. Additionally, to maintain API compatibility, this rewrites plugins still expecting the old type.

Machine-Maker avatar Nov 04 '22 23:11 Machine-Maker

Maybe a .paper() method inside the Bukkit PlayerProfile can also improve the upgrading experience to paper's solution?

TheFruxz avatar Nov 10 '22 18:11 TheFruxz

We've already hardline no'd a paper() method, it just creates so much pointless call cludge to avoid the odd cases where upstream does something which screws us over, and just creates a messy dev experience

electronicboy avatar Nov 10 '22 20:11 electronicboy