e82eric

Results 53 comments of e82eric

Sorry, didn't mean to rush you, was more worried I was spamming you guys with all of these fuzzy finding PRs. Please let me know if it doesn't make sense...

> I'm also somewhat confused by the code's dissimilarity with the original fzf to be honest (that's not an issue in on itself; it just surprised me). I think there...

> That aside, for the upcoming project that I've worked on, I ported VS Code's fuzzy matcher to Rust. Here's the original: https://github.com/microsoft/vscode/blob/071eafaf5ab4de3814466b616fe00a66d2739ad2/src/vs/base/common/fuzzyScorer.ts If you'd like I could generate a...

Updated the PR to use the VsCode algo from the Edit repo, wanted to see how the results compared to the fzf port. It was more or less like you...

> Things have finally settled down in the edit repository and I now have plenty time to review your PR. If you prefer the fzf approach, I'd be happy to...

Pushed one more set of updates. I had a logic issue here where the query wasn't being passed to the fuzzy searcher (https://github.com/microsoft/terminal/commit/fbf76f2d26986e6f4290336afe415f63d7ed37aa wasn't working at all) https://github.com/microsoft/terminal/pull/18700/commits/8bacdcf15a0d99e40aa9ade2fcc2d93e5802e735 should fix...

> The only commit that's a little unlike the others is "Simplify & improve performance of UTF16UTF32 routines". It only works well if the needle size and hit count is...

> > If so I think I could update the new function to include both positions for the pair (I like the new approach a lot better that the map...

> > The other thing that I am worried about is that I still haven't figured out how to run LocalTests_TerminalApp which will probably have some failures from the new...