e82eric
e82eric
@j4james thank you! that makes sense. Feel free to close this issue. (I had noticed it and wanted to see if I could sort out what was going on). I...
@j4james sounds good. I ran a time travel trace to see if I could find anything on why it did the weird jump with those lines commented out. It looked...
I think the cause of this is that when a Refrigerated window is restored this call to Controls::Grid::SetRow(_titlebar, 0); causes the _title bar to be visible. https://github.com/microsoft/terminal/blob/63c3573a13cc96bfa3d655f0f1898ae250e2fe35/src/cascadia/WindowsTerminal/NonClientIslandWindow.cpp#L379 And when the...
I think it is from TerminalWindow::_pageInitialized https://github.com/microsoft/terminal/blob/375d00d0cd2c2934b0d136dcf7c295a5f99b07d5/src/cascadia/TerminalApp/TerminalWindow.cpp#L248 https://github.com/microsoft/terminal/blob/main/src/cascadia/TerminalApp/TerminalPage.cpp#L3554 This was the call stack ``` WindowsTerminal.exe!AppHost::_FocusModeChanged(const winrt::Windows::Foundation::IInspectable & __formal, const winrt::Windows::Foundation::IInspectable & __formal) Line 787 C++ WindowsTerminal.exe!`winrt::Windows::Foundation::TypedEventHandler::TypedEventHandler'::`1'::::operator()(const winrt::Windows::Foundation::IInspectable & , const...
Thanks! Totally understand, no rush on my end.
> okay so what if we did this as a type of pane content, instead of as a part of the control itself? It could be like, the "Find All"...
> > by pane do you mean something like the docked areas in visual studio > > Sorta, yea. In the chain of PRs that terminated in #16914, we added...
@zadjii-msft not sure if it helps, this is what it looked like when I had the search control below the swap panel. I think visually that would be similar to...
Makes sense, I think the main thing is that the pane would need a reference to the Terminal instance (or some proxy/interface) to read the contents of the buffer, set...
@zadjii-msft I can give it a try and see how it goes. Its probably a long shot that it would be something you would want to merge but it feels...