Kévin Dunglas

Results 836 comments of Kévin Dunglas

Actually Laravel Octane only needs pcntl for the CLI SAPI... to start FrankenPHP. FrankenPHP itself doesn't need nor use pcntl. It should be possible to install pcntl for CLI but...

@lermontex it's the same situation for Symfony Messenger. pcntl is only needed to run the consumer command (CLI), FrankenPHP (with the notable exception of the `php-cli` subcommand) runs the web...

Could you please report this bug to PHP directly, as this doesn't look specific to FrankenPHP (and there is nothing we can do about that in this code base).

@lermontex we can document it in the "known issues" page! PR welcome. Thanks to the reproducer, this bug shouldn't be too hard to fix. I have a very busy week...

Thanks for the reproducer. I can reproduce the bug on Mac using the latest version. I'm on it.

https://github.com/dunglas/frankenphp/pull/857 fixes the problem on my side. I don't think that it's related to pcntl. Could you try this patch to see if it fixes the issue for you too...

@withinboredom @TimWolla would you mind reviewing the proposed fix? I need to do more testing to ensure that the behavior is what is expected, but at least this fixes the...

Thanks for your detailed review @TimWolla. Regarding the Docker container, it is entirely optional. When you have a local installation of PHP, you can just run this command to compile...

I pushed a new version that uses `ZVAL_COPY` as suggested by @TimWolla. This should fix the leak (to be double-checked). This behaves almost as expected but I identified two issues:...

The behavior is now the expected one. If you don't mind, cloud you please review again?