Kévin Dunglas
Kévin Dunglas
It's a good start! We also need to take into account the `Vary` header. To do so, we need a second level of cache. Several responses can be stored for...
No. Vary is typically a response header, not a request one.
It still happens with DomCrawler v4.
Why would it crash? The code I wrote should be robust enough to not crash and is already configurable: you can use data attributes to customize the CSS selectors to...
> But handling all [data-prototype] as a collection This isn't what the code does, it only targets the children of the HTML element using the controller (and it's not mandatory...
> Shouldn't we also ship the dist/controller.d.ts file alongside the compiled JS code ? Declarations are entirely disabled for the whole project. I don't know why (cc @tgalopin) but if...
I added an example confirming that nested dynamic controllers are well supported, e.g if you use Dropzone in a form type that is added dynamically when clicking on the "add"...
@javiereguiluz here is a recording: https://user-images.githubusercontent.com/57224/180029620-8bb52bab-7fb0-4cd4-89e4-b52c32b34dcf.mov
400 looks interesting. I think we have a choice to make: - either we remove the HTML generation code needed for this feature from core and move it in UX...
Does this approach support nested dynamic collections (here is a test case: https://github.com/symfony/ux/tree/e901026aa1d2e2cd2b27a5796962bc8fc4b5dcca/src/Collection/Tests/app/Form)? For the record, I proposed an alternative patch in https://github.com/symfony/ux/pull/398 which doesn't require changing the existing forms...