Kévin Dunglas

Results 823 comments of Kévin Dunglas

@nicolas-grekas done. The failure looks unrelated, or am I missing something?

We could at least put that in a `render_esi()` call. It will work by default for everybody, but will stay HTTP cache-friendly (you'll just have no cache on this specific...

Just another template. You can render it using the builtin `TemplateController` with something like this: `render_esi(controller('Symfony\Bundle\FrameworkBundle\Controller\TemplateController', {template: 'flashes.html.twig'}))`

Why don't you run your PHP commands inside the PHP containers instead of on the host?

This shouldn't be an issue because we use a pattern (and because our CI is green). Please check that you aren't running an outdated version of Docker or Docker Compose.

Can you try with Docker Compose v2 please? We upgraded the setup this week.

Indeed. I wonder if we cannot find a way to conditionally add these files that is compatible with both versions of Compose.

@maxhelias do you think we can merge this one?

In #271 I introduced a dev stage. Maybe could we install Node in this dev image?

Awesome! As it's a relatively specific use case, I would prefer to not add too much "unnecessary" comments to the skeleton itself. Could we just add a doc entry explaining...