David Snopek

Results 604 comments of David Snopek

> Unsure why this was the case originally, but the change would have to be limited to changing the documentation, anything else would break compatibility Yeah, changing this would likely...

Possibly the same issue as https://github.com/godotengine/godot/issues/82817

I'm able to reproduce this issue still (although, I think we may have fixed and re-introduced it at least once since this issue has been created - maybe even more...

> Does anyone know why the unit tests are failing? It's unrelated. Re-basing on `master` will fix it. I had this on some other PRs I was working on as...

Since we can do it in the engine, I think it makes sense that we should be able to do this in godot-cpp as well! However, I think this will...

Thanks for the MRP! It took a few little changes, but I got the project generating a tone on Linux. Then built and exported for the web, and I'm getting...

The error seems to be coming from when `AudioStreamPlayback::mix()` (on the Godot side) calls into the GDExtension to run `AudioStreamPlaybackMyTone::_mix()`. This might not mean anything, but I find it interesting...

Hm. So, `AudioStreamPlayback::_mix()` in Godot is actually declared as taking a `float` for the 2nd argument, and that's what's in the `extension_api.json`. But for some reason, in `binding_generator.py` the `correct_type()`...

I think the next steps here are probably to narrow down if some part of the function signature is causing the issue here. I think I'll try declaring a virtual...

> I'd hold off cherry picking this, if at all (also for 4.1) We can hold off while figuring out the issue with `SAFE_NUMERIC_TYPE_PUN_GUARANTEES(uint64_t)`, however, I'd really like to cherry-pick...