godot-cpp icon indicating copy to clipboard operation
godot-cpp copied to clipboard

Cherry-picks for the godot-cpp 4.2 branch - 1st batch

Open dsnopek opened this issue 1 year ago • 4 comments

The 1st batch of PR's marked with cherrypick:4.2

dsnopek avatar Jan 22 '24 21:01 dsnopek

See discussion on:

  • https://github.com/godotengine/godot-cpp/pull/1357

I'd hold off cherry picking this, if at all (also for 4.1)

AThousandShips avatar Jan 22 '24 22:01 AThousandShips

I'd hold off cherry picking this, if at all (also for 4.1)

We can hold off while figuring out the issue with SAFE_NUMERIC_TYPE_PUN_GUARANTEES(uint64_t), however, I'd really like to cherry-pick this eventually. Without this change, GDExtensions compiled with the 4.1 or 4.2 versions of godot-cpp will be subtly incompatible with Godot 4.3+ if they get a packed array or string with enough elements. And developers may choose to build their extension with the 4.1 or 4.2 version of godot-cpp to make it compatible with more versions of Godot.

dsnopek avatar Jan 23 '24 00:01 dsnopek

I'd suggest just removing it from this and not hold this batch back, will do some further looking into that bug but been having problems testing 32 bit builds, but will look back into it

AThousandShips avatar Jan 23 '24 09:01 AThousandShips

Ok, I've removed the cherry-pick of PR https://github.com/godotengine/godot-cpp/pull/1357 for now

dsnopek avatar Jan 24 '24 14:01 dsnopek