Dillon

Results 97 comments of Dillon
trafficstars

I believe this circuit has a few issues. One of them is a bug, fixed in the above commit. The other issue is the capacitor and diode directly connected from...

Going to keep this open because I think this circuit should still simulate OK with the diode and capacitor in place. I was thinking that the diode would have absurd...

I think it's unlikely to matter. Pots and resistors aren't that different, and 'Variable resistor' is exactly the same. Really the only issue with this circuit is the capacitor solving...

I don’t think any of the issues being looked at in this thread are actually related specifically to JFETs, they should be working.

This branch needs to merge master in order to merge. There are no conflicts, but there are breaking changes: the params type is now a struct and not a union.

There are some new flaky tests that seem related to this PR: https://github.com/google/XNNPACK/actions/runs/10857812047/job/30134876420?pr=7089 Can you please take a look?

Sorry for the churn here, but we are moving away from this style of benchmark, in favor of subgraph API benchmarks, which are "more end-to-end". These operator API benchmarks really...

Supporting more SPICE models is something I've wanted to do (#22), but haven't gotten to in part because it is a long tail of challenging cases to support. It's not...

It's possible there are interesting ways to approximate parts of circuits, but there is a huge set of possible solutions to consider, and I think any one of them is...

I think FP16 really is a necessary dependency, it's not optional for optimization. The thing that would need to be optional is support for float16 ops, which AFAIK is not...