XNNPACK icon indicating copy to clipboard operation
XNNPACK copied to clipboard

Published 20 hours ago • verified publisher icon google

Add support for RVV f32-qs8/qu8-vcvt microkernels, test and config.

Open KaustubhIMG opened this issue 1 year ago • 2 comments

KaustubhIMG avatar Aug 26 '24 11:08 KaustubhIMG

Related to: https://github.com/google/XNNPACK/pull/6908

oliIMG avatar Aug 28 '24 07:08 oliIMG

@fbarchard @allenkelly @bhbruce @keeranroth, If you have time, please help review this PR.

KaustubhIMG avatar Aug 28 '24 09:08 KaustubhIMG

note the qu8 is not used much... we are trying to move away from qu8 and use qs8 and qd8 for gemms. f32-qs8-vcvt is used alot. we may want f16-qs8-vcvt too

there are global changes to do with params and tests that may require rebasing

Currently no patch is ready for f16-qs8, will consider this in the future. Also regarding qu8, it's not much more work to add support for this, but would you like to no longer include qu8 kernels going forward?

oliIMG avatar Aug 30 '24 10:08 oliIMG

This branch needs to merge master in order to merge. There are no conflicts, but there are breaking changes: the params type is now a struct and not a union.

dsharlet avatar Aug 30 '24 22:08 dsharlet

@dsharlet @bhbruce could you rerun the tests and merge, I've solved the conflicts.

oliIMG avatar Sep 06 '24 13:09 oliIMG

Already merged

KaustubhIMG avatar Sep 12 '24 04:09 KaustubhIMG

There are some new flaky tests that seem related to this PR: https://github.com/google/XNNPACK/actions/runs/10857812047/job/30134876420?pr=7089

Can you please take a look?

dsharlet avatar Sep 14 '24 01:09 dsharlet

@dsharlet Added fix in https://github.com/google/XNNPACK/pull/7096

KaustubhIMG avatar Sep 16 '24 06:09 KaustubhIMG