Daniel Schep

Results 138 comments of Daniel Schep
trafficstars

Not a bad idea. However, I think the payload should be JSON encoded. eg `payload = json.dumps({"title": title, "message": message})`

That's very odd, ntfy's setup.py should pick the right version: https://github.com/dschep/ntfy/blob/master/setup.py#L12 What distro are you using and are you using a virtualenv?

Hey @st3fan, this looks good for the most part. However, some time ago, I added the [capability for ntfy to load backends from 3rd party modules](https://github.com/dschep/ntfy/blob/926b9fd52cb3ee13a90f14949db962e48134cd0a/ntfy/__init__.py#L41-L45), my official recomendation is...

note, for discoverability, I'll still gladly accept a PR adding the new backend to the list of backends just as I've added for webpush once you've published your own package

It's only a problem for me because I get daily PRs, not one for each package. For PRs-per-package, I don't think anything needs to change. If using daily PRs, it'd...

Thanks for those docs @jayfk, I'll use that as a workaround so I can still merge the PRs for now.

You might want to specify which provider you're querying :wink:

200 is the HTTP code for `OK`, not an error. To get the data out of the response object, you'll want `results.json()`

I wonder if this is in part due to their being acquired by lyft 🤔 You can find most systems data by going to their website. IE, for divvy: 1....