Daniel Schep

Results 138 comments of Daniel Schep

Yeah, in general it seems like something derived from `protect_class` would be better international use. I think it goes without saying that I consider the presence of the original values...

Hi folks. I'm curious what's holding up this PR. The current master branch creates an un-usable style. I'd imagine your cartographers would dislike big black blobs way more than slightly...

I'll try. I don't actually have OMT dev env setup currently. I'm mostly just consuming tiles 😶

Ignore that test I added, it passed on main too 😬

AFAICT shadow DOM doesn't behave the same in jsdom as in real browsers, so this can't be tested that way 😞

sorry, @HarelM, haven't had time to dig into adding an integration test yet. I'll try to get to it this weekend.

>Surprisingly enough I was able to push code to your branch, didn't know this was possible. Yep, that's an option that can be enabled on PRs, I guess it was...

I get build errors for some reason (also when doing `npm start`): ``` $ npm run build-dev > [email protected] build-dev > rollup --configPlugin @rollup/plugin-typescript -c --environment BUILD:dev loaded rollup.config.ts with...

That seems to work. I'll try and get a PR for this up soon.

Yeah, not sure why it stopped working. I don't think I made a change that caused it to break. Alas... updating the readme will more likely be to reflect I...