Douglas Blank

Results 381 comments of Douglas Blank

> This PR reminds me of the [db.collcetion.find](https://www.mongodb.com/docs/manual/reference/method/db.collection.find/) method in MongoDB. It may be worth a quick look if you are unfamiliar with it. You may get some ideas. Thanks...

> I am not sure what the intented use of DataDict is, but I recommend using Primary object types rather than DataDicts wherever possible (as return types and arguments of...

> because otherwise I suspect we'll be seeing a lot of AttributeErrors or alternatively have to sprinkle the code with assert hasattr BTW, `DataDict` is a drop-in replacement in terms...

Here is an example of where we would need to be careful about falling back to a regular loop through the data in the case of a proxy: If #1794...

Bah! @stevenyoungs pointed out that the proxies properly process raw data. All my worrying above, and some of my comments about `DataDict` and raw data are wrong. `DataDict` should be...

> the get_raw_* functions in a proxy look like they create the true object in order to do the filtering. So I agree, not efficient, but should give the correct...

Asked for comments on the gramps-dev mailing list.

> I'll start the discussion if nobody replies, That would be great.

@Nick-Hall, IMO no serious objections raised on gramps dev mailing list. This PR would probably make a good candidate for 6.1. If accepted, I could update some filters to make...

@Nick-Hall, I'm starting to work on some parts for Gramps 6.1 (the proxy refactor #1952 is actually ready for review.) I know that you are quite busy getting 6.0 beta...