Douglas Blank

Results 381 comments of Douglas Blank

Looking very clean!

> Why are GrampsType, Date, StyledText and StyledTextTag not derived from BaseObject? I always wondered that too.

I just tested the conversions (to and from) on all objects in the "Example" Gramps tree, and everything checks out. I added a `from_struct()` in `gramps.gen.merge.diff` for completeness and convenience....

I can add to those tomorrow.

Actually, the serialize_test.py covers everything that I just tested. Wonder why? I wrote that 11 years ago :)

Looks like tests are finding that the objects don't have "handle" set for some reason. Oh, I see: those are the tests that are only partial JSON. Yes, no worries...

I tweaked your `__object_hook()` a little, and made all of the `set_object_state()` methods return `self`, and now it appears to be **faster** than `Object.create(pickle.load())` version. ```python def __object_hook(obj_dict): _class =...

I'm not getting times like you report. I'm running Python 3.10.13 running on a laptop (SSD drive, 16GB RAM, Intel i7, Dell XPS 13, Ubuntu 23.10) I'm getting: Pickle +...

On a much bigger, newer machine (Python 3.10.15, Ubuntu 22.04, 64GB RAM, SSD drives, AMD® Ryzen 9 7950x 16-core processor × 32, 64 bit), I get (on the same code...