Douglas Wilson

Results 1985 comments of Douglas Wilson

> Is that sufficient to drop CI for EOL Node.js versions? Not necessarily unless there is no possible solution otherwise. The standard Node.js issue template usually asks folks what alternative...

I'm not sure if that comment was made in good faith and instead out of frustration. Maybe you need to cool off? I'm not sure I should provide a response...

oo, I think we can definitely make the ETag generation skip if there is a certain `Cache-Control` header for sure. As for if you need something immediately, you can use...

> Are you going to add the Cache-Control condition or should I make a pull request? I think it's a great idea :) I do want to consult some RFCs...

So the PR has been rejected, because it turned out that bit about `no-cache` was just an assumption; browsers still consult the `ETag` and make conditional requests, even with `Cache-Control:...

> Any ideas on how to implement ETag control on a per request basis? It's not easy, but I'm working on it :) We basically want you to be able...

Hm, that is a good point. I don't think such a change would be backwards compatible, but it could potentially be changed in a future major version of Express. I...

Hi @webketje thanks for your input. We are trying to refrain from continuing to snowball the 5.x release with endless changes, and ideally just the last few on the list...

> maybe there is no "right way" You are correct in that there is no "right way" in Express; folks are free to organize however they like, ultimately :) Of...

Hi, and thank you for your thoughts! Besides the change from CJS to ES modules (which is not going to happen any time soon in Express), pretty much all your...