Douglas Wilson
Douglas Wilson
> I didn’t view this as a breaking change so that’s good to know It doesn't seem like it on the surface, but there is a behavior change here, of...
Love it. There hasn't been any objections or anything, and finally gets rid of those annoying overloads like `.get(setting)`. I plan to land this right in the next 5.x release...
Sweet, that will help a lot 👍 I had noticed two things, mainly, from looking through it at a high level: (1) cap the dependency to `~` instead of `^`...
@arjunrp sample code is in the first post. all the code is one example, just split up by the explanation.
i just retried and it's still broken. here is the simplest example to demonstrate: ``` js var express = require('express') var app = express() var router = express.Router({ strict: true...
@danieljuhl the issue is really a fundamental functionality of API guarantees within the router. The only work-around right now is to make both routers strict (your app with strict routing...
@danieljuhl the work-around was posted above in https://github.com/strongloop/express/issues/2281#issue-39535754 by the original user :) For the code you posted, here is the work-around added to it: ``` js var express =...
It's an extremely difficult fix, but can be done, just needs some effort for probably 5.0. I'll fix the labels :)
The issue here is with Express and the way the `router` works, rather than anything with `path-to-regexp` :) Essentially what happens in the reported case is that `req.url` will never,...