Douglas Wilson

Results 1985 comments of Douglas Wilson

Closing this issue as the changes where already merged in to master, but the issue wasn't referenced on accident so the issue was not closed automatically.

If someone wants to start a PR to add promises, that would be a big help :)

It is probably no an issue with this package, as this package has no functionality to set cookies at all. It just reads the incoming `Cookie` header and places them...

I totally understand, cookies can be complex with various security segments in the web browsers. I have to admit, my front end knowledge is rusty, especially with all the changes...

Hey @jonchurch would you be willing to make a pull request to the router repo to add Promise support to `router.param` ?

For some reason the test is not happy on Node.js 0.10. That may not actually be a problem with Express 5.0 target, just wanted to call out why the CI...

Closing as this has been fixed in the routing system itself now.

Hi @erunion I'm not sure who marked them that way, as the project has various triagers who help with issues. I unhid them if that makes you feel better. As...

@erunion I added some inline comments on the code issues. Tests can easily pass when they are incomplete, which is the case here. Tests need to be built out as...

Hi @erunion it was happened on the CI server (though that whole things needs to be migrated now that Travis CI is gone), but also locally on Node.js 18 (node...