Douglas Wilson

Results 1985 comments of Douglas Wilson

Looking at my branch, it looks like I have an intermediate change I can actually push up that reduces the size by 70kb even.

I will need to take a closer look at my changes tomorrow or so 👍 hopefully I can land them here soon.

This change sounds good to me! I wonder if there is any way we can add a test or not. No big deal if it's not possible or practical, just...

Someone needs to provide a reproducable example we can run and see the issue or please make a PR. I cannot reproduce the issue so far just guessing at what...

Hi @t-araujo nothing aeems wrong with that. What kind of problem are you having with that code?

Hi @t-araujo interesting. The test suite and my own apps don't seem to have an issue. I wonder, is your app behind a proxy? If it is, have you set...

Hi @bryantamayo1 very sorry for your issue. Unfortunately your issue would likely be outside of `morgan`, as all the `:res[content-length]` token does is show the value of `res.headers['content-length']`, which it...

Hello, and thank you for your suggestion. The goal of the configuration for this middleware is to be as static as possible. Can you elaborate on the specific use-case you...

Hi! That is very strange, as normally you should not see any logs from Morgan for websoxket requests, as websockets are not something that Express handles at all (and this...

Hi @loynoir thanks for reporting! As far as I am aware, all versions of Node.js have that function, and also the error looks weird and there is no stack trace....