Douglas Wilson

Results 1985 comments of Douglas Wilson

yea, but i think we may have ruled out the event loop blocking, because looking at this new log, it looks just like the others in that the blocking was...

> Just wondering what's the reason for it. `this.setTimeout(0, handleConnectTimeout);` is the wonderful API node.js provides to _remove_ a timeout. The code there sets a timeout on the socket and...

> It's like slowing things down a little actually give the lib the opportunity to connect. Because `console.log` is implemented to actually flush out to the fd on most platforms...

Yea, but `mysql2` does not implement timeouts of any kind :) So if your issue is something timeout-related, then it would not have the issue, haha.

OK, that's no problem :) I just wanted to point it out, haha. I would like us to solve this still if you're interested is why, in case you were...

@matthew-dean-hp are you using the `PoolCluster`?

@DasithKuruppu I haven't been able to reproduce and so no work has been done. If someone can suggest a fix who can reproduce and verify it, that would be great...

As for this change, I definitely think it needs to wait for 3.0, probably going along with actually fixing the way encoding works in this module, which is still fundamentally...

Ah, @dresende, I see why the tests are failing: you committed failing commits directly to master. Please revert commits on master that fail CI. Please us branches to test commits...

@dresende for now I just moved those commits over to this branch so we can take whatever time is needed figuring out what the test failures are and can get...