Douglas Wilson

Results 1989 comments of Douglas Wilson

Yea, that seems doable. Pull requests are definitely welcome!

Really, I could see it either way. I think that (and this is just thinking out loud) it would make sense if we could at some point have in the...

So it's just not yet a completed implementation. In order to determine the charset of the contents, the spec https://www.w3.org/TR/html5/forms.html#url-encoded-form-data spells out the steps to do this. UTF-8 is the...

Hi @rodic normally, that type will never have a `charset` in the header at all; it's only present in some buggy version of Firefox. The spec says that the charset...

That's an interesting question, actually. It seems currently if your store is offline, then this module will pass the `misconfigured csrf` error down your pipeline to just 500. So, clearly...

What we can do is if the request doesn't qualify as one that needs validation (i.e. is a GET and not like a POST), then we can delay the error...

Currently only the methods that are sync return the object back; the objects that take a callback in order to continue do not return the object, because you'll end up...

A disclaimer probably saying that `req.next` should only be used as a last resort, and that there are various edge cases where it may not actually refer to what a...

So this has been a similar issue for the `express-session` module, as it relies on folks implementing store plugins to be useful to the general population. Of course, actually vetting...

Hi @brandon-d-mckay I think that can be a good idea. If we do that, we'd probably want to be able to explain to people what exactly they need to do...