Mathieu Pillard

Results 203 comments of Mathieu Pillard
trafficstars

Less of a priority now that DMARC setup has been adjusted to verify our emails as valid in https://mozilla-hub.atlassian.net/browse/IO-2807 Although it's probably a good idea still to move to `addons.mozilla.org`...

Yes - but AFAIK the build is specific to the env at the moment, so we would either need to pre-build all envs or find a way to ensure the...

Reworded STR: - Go to https://addons.mozilla.org/en-US/firefox/ with Firefox for Android (the `/firefox/` part of the URL matters, as well as using Firefox for Android - this is not the "right"...

Every issue that is still opened deserves a fix, but we don't have capacity to fix everything. I'll gladly review a patch for this if someone wants to give it...

Yes, this is not a new issue. The root cause is similar to https://github.com/mozilla/addons/issues/4000 - the model doesn't have a `default_locale`, and if it did it wouldn't necessarily follow the...

This doesn't lead to an error - the file is signed correctly, the ID provided in the URL is completely ignored. If the developer was making a manual API query...

Ah yes, for an update it would lead to an error. When I tested this before posting my comment above I used with an entirely new add-on, didn't remember this...

> does the linter check for the correct GUID format in the manifest if defined? [Yes](https://github.com/mozilla/addons-linter/blob/c4348a28829ac8cd214f2202f7f796c8a24878bd/src/schema/imported/manifest.json#L713).

We need to go back to addons-server then and modify the API to make these fields proper CharFields (which will require database migrations)