addons icon indicating copy to clipboard operation
addons copied to clipboard

Custom Licence name returns null for requests made in a locale different from the original set-up

Open AlexandraMoga opened this issue 7 years ago • 8 comments
trafficstars

Similar to https://github.com/mozilla/addons/issues/5266

STR:

  1. Submit a new add-on while your locale is set to en-GB
  2. In the submission details flow, add a Custom Licence with a name of your choice
  3. After the add-on is auto-approved, get the api details of your add-on in en-US, i.e https://addons-dev.allizom.org/api/v4/addons/addon/{your-addon}/?lang=en-US
  4. Check the "license": {..."name" value

Actual result: The license name is null

Expected result: The license name should contain the value given by you during submission, regardless of the locale in which the request was made

Notes:

  • example https://addons-dev.allizom.org/api/v4/addons/addon/greatly-for-firefox/?lang=en-US

image

As seen on the frontend:

image

┆Issue is synchronized with this Jira Task

AlexandraMoga avatar Nov 12 '18 11:11 AlexandraMoga

Yes, this is not a new issue. The root cause is similar to https://github.com/mozilla/addons/issues/4000 - the model doesn't have a default_locale, and if it did it wouldn't necessarily follow the add-on's default_locale either, so that messes up cases like these.

diox avatar Nov 12 '18 11:11 diox

This issue has been automatically marked as stale because it has not had recent activity. If you think this bug should stay open, please comment on the issue with further details. Thank you for your contributions.

stale[bot] avatar Sep 06 '19 16:09 stale[bot]

This is still a valid issue

AlexandraMoga avatar Sep 10 '19 09:09 AlexandraMoga

This issue has been automatically marked as stale because it has not had recent activity. If you think this bug should stay open, please comment on the issue with further details. Thank you for your contributions.

stale[bot] avatar Mar 08 '20 10:03 stale[bot]

This issue has been automatically marked as stale because it has not had recent activity. If you think this bug should stay open, please comment on the issue with further details. Thank you for your contributions.

stale[bot] avatar Jan 08 '22 22:01 stale[bot]

Still an issue

AlexandraMoga avatar Apr 13 '22 11:04 AlexandraMoga

Old Jira Ticket: https://mozilla-hub.atlassian.net/browse/ADDSRV-172

KevinMind avatar Apr 26 '24 11:04 KevinMind

Old Jira Ticket: https://mozilla-hub.atlassian.net/browse/ADDSRV-172

KevinMind avatar May 03 '24 15:05 KevinMind