Mathieu Pillard

Results 203 comments of Mathieu Pillard
trafficstars

We discussed that on slack, and here is a summary of that discussion with some added background: - Blocking in itself is a silent action and we don't notify developers...

https://bugzilla.mozilla.org/show_bug.cgi?id=1479111 mentions both collations and it looks like we had a problem switching existing tables to `utf8mb4_unicode_ci`: > mysql> ALTER TABLE addons CONVERT TO CHARACTER SET utf8mb4 COLLATE utf8mb4_unicode_ci, LOCK=SHARED;...

A summary of the mess we're in: - Most of the old tables, `addons` in particular ([also `users` because of `username`](https://github.com/mozilla/addons/issues/1812), but that column is less important nowadays and we...

We now have a query that can identify problematic slugs: `SELECT slug, count(*) AS cnt FROM addons WHERE slug IS NOT NULL GROUP BY slug collate utf8mb4_0900_ai_ci HAVING cnt >...

We eventually switched to MySQL 8.0 (in https://github.com/mozilla/addons/issues/8043 and https://bugzilla.mozilla.org/show_bug.cgi?id=1666431) and that means that we should revisit default collations again. https://github.com/mozilla/addons/issues/15032 is an example of something that can fail or...

Also note that new local/CI environments are already different from dev/stage/prod, since they should already be using `utf8mb4_0900_ai_ci`, where as dev/stage/prod are still on a mix of `utf8mb4_unicode_ci`/`utf8mb4_general_ci`.

This had dropped from my radar but we should still try to do it. The info could live on `VersionReviewerFlags`.

https://github.com/mozilla/addons-server/pull/21233, my prototype for https://github.com/mozilla/addons/issues/9295, would do this as a side effect.

> with domain restrictions , email user restrictions or ip network user restrictions when the restriction type is Submission, I think the Activity log registers 3 reports that seem to...