addons icon indicating copy to clipboard operation
addons copied to clipboard

After a block, /developers/addon/<addon_id>/versions is 404

Open Rob--W opened this issue 3 years ago • 2 comments

Describe the problem and steps to reproduce it:

A developer reached out to me that their add-on is blocked for an unknown reason, and they couldn't find relevant (review) messages in their e-mails.

I suggested to visit the developer account, and click on the "Status & Versions" part at their add-on, i.e. visiting https://addons.mozilla.org/en-US/developers/addon/<addon_id>/versions

What happened?

The page cannot be found. It shows "We're sorry, but we can't find what you're looking for."

What did you expect to happen?

The list of versions and statuses should be visible, along with the links to the Review History that includes the rejection reasons.

Anything else we should know?

PM me for details of the specific add-on if needed for debugging.

┆Issue is synchronized with this Jira Task

Rob--W avatar Sep 07 '22 15:09 Rob--W

We discussed that on slack, and here is a summary of that discussion with some added background:

  • Blocking in itself is a silent action and we don't notify developers for that - the versions would be shown as "Rejected" without a reason. This is because it's generally done when the developer is so blatantly violating policies (usually their add-on is heavily obfuscated or evidently malicious) that giving more details is a waste of our time. Reviewers are however technically free to elaborate if they want by adding more comments if needed.
  • When all versions of an add-on get blocked, the add-on gets force-disabled, preventing any new versions from being submitted. This was an explicit ask in https://github.com/mozilla/addons/issues/7206
  • In that state, if you're an author (or an admin with Addons:Edit permission), you can see view the Status & Versions page, but you can't delete the add-on any more, nor upload any new versions: the links/buttons to do that will be hidden and manually visiting the corresponding page will result in a 404 (https://github.com/mozilla/addons/issues/3740, but the general logic behind that is a 15 years old product decision)
    • However, there is an exception to that: if the add-on did not have any listed versions, then on top of those restrictions, only admins can access the devhub page. This is what's happening here.

We could change this - it would require tweaking the very old addon_view decorator, which used to be shared between frontend, devhub and reviewer tools back in the day, and is the source of our troubles... But before doing that, I'd want confirmation from Operations and Product that this is ok to do.

diox avatar Sep 19 '22 13:09 diox

Old Jira Ticket: https://mozilla-hub.atlassian.net/browse/ADDSRV-119

KevinMind avatar May 03 '24 17:05 KevinMind