David Holmes
David Holmes
> @dholmes-ora would you mind sharing your opinion? We seem to be making things more complicated, but hopefully in a good way? Seems very complicated to me. Really this is...
I consider moving declarations around trivial; as functionally there is no impact. There could be a performance impact but it is very unlikely that anyone would know for certain during...
Are there no tests that enable this flag and so would need updating to unlock it correctly?
> and whatever team is responsible for HotSpot debugging. I don't see anything hotspot related here. I think you would be better off splitting this up into distinct issues and...
> Aren't the dt_shmem and jdwp changes related to HotSpot? Nope. That's core-svc - the non-hotspot side of serviceability. :)
> the way I did it I'd have to force push That should not be the case. You can just anti-delta changes.
> I do wonder if mutex support can be implemented for Windows with Acquire/ReleaseSRWLockExclusive. A `CriticalSection` is a mutex. A RWLock is not a "mutex".
But if it can't be empty can we not just assert that and get rid of the is_empty check from is_executable?
My concern is that the logic was wrong and so you fixed it, but this then screams out for a test that would have detected the error, but you can't...
> Do I understand this right that the suggestion is to add an explicit runtime check for non-emptiness and report an error if an empty line has been discovered? If...