David Holmes

Once the changes to the jcmd manpage are finalized please ask someone from Oracle serviceability to apply the changes to the closed sources and regenerate the troff file to ensure...

> I consider the "format '%p' expects argument of type 'void*" warnings to be not at all helpful. Fortunately we don't use '%p' in HotSpot, We do use it in...

I'm also having trouble understanding problem and solution here, but mainly because I don't understand what the jtreg code is supposed to be doing anyway. I'm surprised to see jtreg...

Whoa! @lkorinth [8317228](https://github.com/openjdk/jdk/pull/15986#top) needed broader discussion for the changes to VMProps.java - what exactly is that change doing?

> I have been starting to change test cases to use `createTestJavaProcessBuilder` instead of `createLimitedTestJavaProcessBuilder` because we severely limit our testing when we use `createLimitedTestJavaProcessBuilder`. Before that change there were...

This seems a rather fragile mechanism. In practice I expect there are only a handful of -X flags tests really care about - and some of them already handled (e.g....

The VM processes -XX flags such that "last value wins" - though in part that is due to convention in that the nature of our flags tend to be absolute...

I'm okay with fixing the bug that was introduced, just so we don't have this crash potential, though I dislike the special handling of `-Xlog` in the code. But overall...

As I said previously I have no objection to this fix dealing with the bug that was introduced by [JDK-8317228](https://bugs.openjdk.org/browse/JDK-8317228). But I think [JDK-8317228](https://bugs.openjdk.org/browse/JDK-8317228) needs revisiting in itself.

> There is not need to start debugger in the separate process for each test. I don't think I agree with that. Don't we want to have the debugger in...