Daniel González Reina

Results 43 comments of Daniel González Reina

Trying to use `` as a Toast title gave me problems. It complained about `` not being in the component ancestry. I imagine this happens because Toast is internally using...

Re: `packages/react-app/src/data/challenges.js`, sounds good. I'll see how it gets the context. Worst case we can initialize it somehow like adding a method like `setChallengesLang` that would set a constant in...

Added more texts and two notes: > - There are some places where the logic to show some content depends on the user being an admin. I think those aren't...

Added more texts and a notes: > - Just to double check with you that's ok to leave the role names in English (at `react-app/src/helpers/constants.js`) > > - Do we...

Awesome! Thanks! I'll update [the comment](https://github.com/BuidlGuidl/SpeedRunEthereum/pull/187#issuecomment-1510358708) with your responses to have it all in one place.

Just realized while looking at the table, that the `DateWithTooltip` shows the relative date like "2 years ago". The YYYY-MM-DD, HH:mm is shown in the tooltip only. There's a [`FormattedRelativeTime`...

I added the last component that was remaining. I think this can be merged as a first iteration. Next iteration would be to check how to use a specific language...

~@carletex I've lost the button to make this a PR instead of a draft. I can only see the option to close it or comment 🤷~ Of course I found...

The best solution I've found is to modify `challenges.js` to return a function `getChallengeInfo` instead of the challenges object. That function receives the `intl` object, so we can do stuff...