Daniel González Reina

Results 43 comments of Daniel González Reina

Sure! I'll get to it as soon as possible. That's hopefully later today or tomorrow 🤞 Thanks for replying so fast :)

Hi @simonsteinberg! Thanks for sharing this PR. I'm looking at the change and the current output is -280, but you propose -208 as the right solution. My question is, wouldn't...

Hi @simonsteinberg! I see your point. In this case it looks like it could be a typo due to having the same characters but in different order 😅 . However,...

That's a very good point. That way we could at least know that the current solution is a valid one. I like it. I'll try to find some time to...

Haha no problem! I think you're right about changing the lines. It's not like it couldn't be done, but it's going to be definitely easier to create a file per...

I'll have a look at the GitHub Actions option. I hadn't thought about that before. Thanks for pointing it out! :)

Thanks for the super fast response! 🙌 I'll try that tomorrow, since Google told me I'm out of resources for today haha So that method would be equivalent to 500...

Cross posting from https://github.com/airbnb/enzyme/issues/1587 I wonder if the following pattern should be enough to solve this problem, and if I'm doing something that is considered bad practice and I shouldn't...

I'd go through each component and replace plain texts with the proper `` components. A bit more tricky can be to find strings outside of the returned jsx. I'd look...

Regarding `packages/react-app/src/data/challenges.js`, I guess the easiest would be to have different files, one for each language (your option 1). The only problem I see with that is that translators might...