David Flemström

Results 60 comments of David Flemström

What is the use-case for committing commented-out code?

I'm going to iterate a bit on the implementation of this PR and test it in various tricky production cases to make sure it is sound, so moving into Draft...

Gonna do some more testing but I think this PR is ready to get new eyes on it.

Wasn't sure if I should add this to all crates... I see that the `fmt.rs` file is copy-pasted into a bunch of places, so I could add this feature to...

With the additional fixes in the last few commits in this PR, I have now eliminated enough call sites that at least for my application, there are no longer any...

Makes sense, and I have looked into the different approaches you list. I will have to resort to using such an approach if we can't find a way to offer...

OK, I will start by breaking out the `unwrap!()` type changes as mentioned as those can be considered a completely unrelated change, and it sounds like we're aligned on that....

I thought I should provide some numbers to show what I'm working with: * My app with vanilla `panic_probe` and upstream `embassy` has a VM size of 33.6kiB * Removing...

> and `panic_immediate_abort`? I wasn't able to test this at the moment because I haven't been able to find a nightly version that works for my build (although I have...

@Dirbaio I have been going deep on this, see this thread for more details: https://rust-lang.zulipchat.com/#narrow/stream/327149-t-libs-api.2Fapi-changes/topic/Flexible.20fmt.20.20API.20that.20allows.20for.20deferred.20formatting I think since `panic_immediate_abort` is not appropriate for my use-case, my next course of action...