David Flemström
David Flemström
Yeah, maybe you're right and I just haven't been able to spend enough time/thinking on about how to make it work. I guess in summary it sounds like you're saying...
I tried to mirror the `core` code for the stable channel in this case: https://github.com/rust-lang/rust/blob/129f3b9964af4d4a709d1383930ade12dfe7c081/library/core/src/panic/panic_info.rs#L160-L178 From what I can see, the deprecation note was added in the nightly channel when...
To me the root reason for making this change is to remove a dependency on `core::fmt` for padding and number formatting, which increases binary size significantly for some embedded applications,...
Haha, well that makes sense! Great! I suppose one has to just patiently wait then... I guess the reason why I didn't make the connection immediately is that `PanicMessage` still...
Hey, great pointers on the nuances between how static msgs are handled vs when they need integer interpolation. To throw another idea on the stack: could `defmt` provide an implementation...
@m-ou-se do you have any leads for how one would best offload the number formatting from `core::fmt` here? I'm happy to give this some more thoughts too but would appreciate...
@Urhengulas thanks for the PR review! As per the above conversation I consider this PR to *not be ready to merge* since we are waiting to learn more from `libcore`/waiting...
@Urhengulas ah sure, we can do it that way, to add `.message()` support at a later point. For now I completely removed the `.payload()` code because as mentioned above the...
@Urhengulas thanks for the pointers! I had gone down the route of trying to enable the compiler-internal feature flag, but even when I tried to disable all the safeguards: ```rust...
For the record, I don't know why the semver check is failing, and I think it is unrelated to this PR.