David Feinzimer
David Feinzimer
I think I wrote a simple reproducer that highlights this problem after encountering it myself. I'm having the same issue testing views that have a task modifier. It seems that...
@philium Can we switch it to `internal` at this point or do we need to mark it deprecated and take it internal at 300?
Note: Swift lint is being added at the SDK level in 200.5 as a plugin. Ref Swift 2836. cc @zkline101 @mhdostal
Note that we ended up adding SwiftLint as a custom package rather than a plugin. See Swift 5164.
Esri fork of SwiftLint -> https://github.com/Esri/SwiftLint ~There're some blockers to integrating the plugin at this time (ref Swift 5176)~ Update: This can be consumed as a package plugin to lint...
> Size-class-specific location of handle: on the bottom of the panel for iPad, at the top for iPhone. Checking off as completed in #74
Reopening as this was going to go into 200.4 but we needed to be reverted due to #678. We'll need to come up with another strategy or wait for SPM...
> Now the "handle" is always on the top. Interesting observation. That would definitely allow us to simplify some of the internals.
Seeing that `BasemapGalleryViewModel` is internal and tied to the lifetime of `BasemapGallery` I think it'd need to be made external and managed by the view using `BasemapGallery or somewhere higher...
Phil left a similar but different idea on improving usability a while back [here](https://github.com/Esri/arcgis-maps-sdk-swift-toolkit/pull/392#discussion_r1295031812).